Ext_proc refactoring: Move stream object from Filter class to client #36228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for better abstraction Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
requested review from
tyxia,
mattklein123 and
yanavlasov
as code owners
yanjunxiang-google
changed the title
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
/retest |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…stream_to_client Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
force-pushed
the
move_stream_to_client
branch
from
e9c2798
to
07a1a77
Compare
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
Kind Ping |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
/retest |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
/retest |
|
/retest |
…stream_to_client Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
/retest |
…stream_to_client Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
tyxia
approved these changes
Sep 25, 2024
test/extensions/filters/http/ext_proc/unit_test_fuzz/ext_proc_unit_test_fuzz.cc
Show resolved
Hide resolved
|
Also, pass it on to @yanavlasov as this pr is to address #35740 (comment) |
yanavlasov
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the required refactoring needed to support HTTP client in ext_proc: #35488
It is also to address a comment of #35740 (comment)